Repository navigation
fix: require a comment with every thumbs-down - #350
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
mimran-khan
force-pushed
the
fix/thumbs-down-requires-comment
branch
from
November 11, 2026 19:02
2115e2c to
5805f8f
Compare
A down vote could be sent with an empty comment. Send stays disabled until the comment has text, and Enter does not submit a blank one. Signed-off-by: mimran-khan <mohammed_imran.khan@outlook.com>
An interrupt with no answer text was treated as a dropped stream, so the run stayed loading and the approval never resumed. A paused interrupt now ends the stream, and the auto-approve test reports the thread as interrupted. Signed-off-by: mimran-khan <mohammed_imran.khan@outlook.com>
mimran-khan
force-pushed
the
fix/thumbs-down-requires-comment
branch
from
November 12, 2026 07:03
5805f8f to
658a499
Compare
AtrikGhosh
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #351
How
Testing
npm run dev)Rollback
Checklist
feat:,fix:,ci:, etc.)npm run lint && npm run test)